Don't decompose Bengali Rra and Rha #977
Conversation
src/hb-ot-shape-complex-indic.cc
Outdated
| @@ -1472,6 +1472,8 @@ decompose_indic (const hb_ot_shape_normalize_context_t *c, | |||
| case 0x0931u : return false; /* DEVANAGARI LETTER RRA */ | |||
| case 0x0B94u : return false; /* TAMIL LETTER AU */ | |||
|
|
|||
| case 0x09DCu : return false; /* BENGAlI LETTER RRA */ | |||
| case 0x09DDu : return false; /* BENGAlI LETTER RHA */ | |||
There was a problem hiding this comment.
“BENGAlI” should be in all caps.
|
thanks for response developers. Now what can I do please tell me. You said this font has a copyright issue so If you want I can send you some free Bengali Unicode font which has too same problem with those particular letters. Please give me some suggestions. |
|
Here I attached few bengali fonts which has same issue in Nuqta dot in Libre Office. |
|
Thanks @ebraminio. The commit adding the existing two (b01d9b3) says it does because uniscribe doesn't. So I'm happy adding these two if uniscribe doesn't either. Would be nice to discover more. |
src/hb-ot-shape-complex-indic.cc
Outdated
| @@ -1472,6 +1472,8 @@ decompose_indic (const hb_ot_shape_normalize_context_t *c, | |||
| case 0x0931u : return false; /* DEVANAGARI LETTER RRA */ | |||
| case 0x0B94u : return false; /* TAMIL LETTER AU */ | |||
|
|
|||
There was a problem hiding this comment.
No need for the new-line here. Just sort these two with the previous two. Also add link to github issue.
ebraminio
force-pushed
the
bengali
branch
2 times, most recently
from
c8f07dd to
2a1a6f0
Compare
|
@kuntalkundu, thanks! |
|
@behdad, applied the changes, have a look if now looks ok. |
|
attaching few more fonts from same font family, Please check |
Fixes harfbuzz#779 and follow up to b01d9b3
Fixes #779, the original font is copyrighted and I wanted to create a subset using hb-subset or pyftsubset but I need a hand here as their result doesn't look correct, so I guess I need to do it manually?
The fix itself looks legit as the same is done for
DEVANAGARI LETTER RRAalso apparently.After the change,