From b5261f024db3d49b6c4b2560257e1128f776813a Mon Sep 17 00:00:00 2001
From: haricane8133 <hari.r.nallan@gmail.com>
Date: Sun, 17 Dec 2023 15:48:38 +0530
Subject: [PATCH] Fixes #7, another dormant bug

---
 ui/src/components/NavLink.jsx | 3 ++-
 ui/src/plugins/fetch.js       | 8 +++++++-
 2 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/ui/src/components/NavLink.jsx b/ui/src/components/NavLink.jsx
index 3fd7b4623..5763dc115 100644
--- a/ui/src/components/NavLink.jsx
+++ b/ui/src/components/NavLink.jsx
@@ -26,7 +26,8 @@ export default React.forwardRef((props, ref) => {
       </Link>
     );
   } else {
-    const href = absolutePath ? url.toString() : cleanDuplicateSlash(getBasename() + url.toString());
+    // Note: + '/' + is required here
+    const href = absolutePath ? url.toString() : cleanDuplicateSlash(getBasename() + '/' + url.toString());
     return (
       <Link ref={ref} target="_blank" href={href}>
         {rest.children}
diff --git a/ui/src/plugins/fetch.js b/ui/src/plugins/fetch.js
index 4467339ce..ed0e51b51 100644
--- a/ui/src/plugins/fetch.js
+++ b/ui/src/plugins/fetch.js
@@ -41,6 +41,12 @@ export function fetchWithContext(
     });
 }
 
+/**
+ * @param {string} path 
+ * @returns path with '/' not duplicated except at ://
+ * 
+ * Note: we need the second .replace() because the first one doesn't catch multiple slashes at the start of the string
+ */
 export function cleanDuplicateSlash(path) {
-  return path.replace(/([^:]\/)\/+/g, "$1");
+  return path.replace(/([^:]\/)\/+/g, "$1").replace(/^(\/)+/, '/');
 }