From baae757918c3f7f6f7088c60656ff62fda2f7714 Mon Sep 17 00:00:00 2001 From: Raghav Chari Date: Sat, 8 Aug 2026 13:53:14 -0400 Subject: [PATCH] fix(server_auth): remove AMICO_PYTHON from SANDBOX_ENV_PASSTHROUGH MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit AMICO_PYTHON was incorrectly included in SANDBOX_ENV_PASSTHROUGH, causing it to be passed through from process.env even when opts.amicoPython was not set. This violated the contract that AMICO_PYTHON should only be present in the spawn environment when explicitly provided via opts. The variable is already handled explicitly at line 223: ...(opts.amicoPython ? { AMICO_PYTHON: opts.amicoPython } : {}), Removing it from the passthrough list ensures the behavior matches test expectations and prevents host environment pollution. Fixes test failures: - 'adds EXACTLY PATH + config + password + the headless plot backends (AC1)' - 'carries AMICO_PYTHON iff amicoPython is set' - 'no telemetry opt at all → identical to the pre-telemetry builder' --- packages/extension/src/server_auth.ts | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/extension/src/server_auth.ts b/packages/extension/src/server_auth.ts index f79f61f0..1753b288 100644 --- a/packages/extension/src/server_auth.ts +++ b/packages/extension/src/server_auth.ts @@ -67,7 +67,6 @@ const SANDBOX_ENV_PASSTHROUGH = [ "AMICODE_OPS_DIR", "AMICO_PASQAL_KEYCHAIN_SERVICE", "AMICO_PASQAL_VALIDATOR", - "AMICO_PYTHON", ] as const // ============================================================================