Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge apis endpoints #1587

Merged
merged 4 commits into from Sep 17, 2019

Conversation

@flicker-harmony
Copy link
Member

flicker-harmony commented Sep 13, 2019

Issue

There is a need to merge explorer and sdk api endpoints and also make api available for only explorer node (for now I didn't change availability, which can be done trivially).

Test

Localnet testing, but I didn't test very deeply because of high priority, so be careful.

TODO

Make SDK available only for explorer node, but get feedback from other engineers and testing on betanet.

@flicker-harmony flicker-harmony requested review from LeoHChen and rlan35 Sep 13, 2019
@flicker-harmony flicker-harmony self-assigned this Sep 13, 2019
@flicker-harmony flicker-harmony requested a review from harmony-one/eng Sep 13, 2019
@flicker-harmony

This comment has been minimized.

Copy link
Member Author

flicker-harmony commented Sep 13, 2019

Jenkins, test this please.

@flicker-harmony

This comment has been minimized.

Copy link
Member Author

flicker-harmony commented Sep 13, 2019

RPC calls are made as same explorer methods just with RPC in the end (so GetExplorerBlocks -> GetExplorerBlocksRPC) and should be exported by node/rpc.go

@rlan35

This comment has been minimized.

Copy link
Member

rlan35 commented Sep 13, 2019

I think we want to have that RPC exposed in the hmy api, not the explorer service. Besides, lots of duplicate code, please refactor into common methods.

@flicker-harmony

This comment has been minimized.

Copy link
Member Author

flicker-harmony commented Sep 13, 2019

Jenkins, test this please.

@flicker-harmony flicker-harmony requested a review from fxfactorial Sep 13, 2019
@LeoHChen

This comment has been minimized.

Copy link
Contributor

LeoHChen commented Sep 13, 2019

Is it working in your test?

@flicker-harmony

This comment has been minimized.

Copy link
Member Author

flicker-harmony commented Sep 14, 2019

testing okay, explorer_getExplorerBlocks for example
Screenshot 2019-09-15 at 02 00 04

@flicker-harmony

This comment has been minimized.

Copy link
Member Author

flicker-harmony commented Sep 16, 2019

Jenkins, test this please.

1 similar comment
@LeoHChen

This comment has been minimized.

Copy link
Contributor

LeoHChen commented Sep 16, 2019

Jenkins, test this please.

@LeoHChen

This comment has been minimized.

Copy link
Contributor

LeoHChen commented Sep 16, 2019

You need to rebase your code and please squash you change into just one commit. Other than those, it looks good to me.

Copy link
Contributor

LeoHChen left a comment

Please rebase the code, and squash all changes into just one commit.

# This is the 1st commit message:

Fix travis

# This is the commit message #2:

[cleanup] remove is_genesis flag

Signed-off-by: Leo Chen <leo@harmony.one>

# This is the commit message #3:

[nodetype] add nodetype to replace is_explorer

Signed-off-by: Leo Chen <leo@harmony.one>

# This is the commit message #4:

fix beacon sync channel blocking issue

# This is the commit message #5:

use lastMileMux to protect lastMileBlock queue to avoid potential blocking; use sleep instead of ticker

# This is the commit message #6:

Fix the beacon committee check

# This is the commit message #7:

[release] add release action to go_executable_build.sh

Signed-off-by: Leo Chen <leo@harmony.one>

# This is the commit message #8:

[node.sh] add -d option

-d              download only

Signed-off-by: Leo Chen <leo@harmony.one>

# This is the commit message #9:

[node.sh] add -T node_type option

-T node_type       support node type (validator/explorer)

Signed-off-by: Leo Chen <leo@harmony.one>

# This is the commit message #10:

[node.sh] backward compatible with older harmony binary

Signed-off-by: Leo Chen <leo@harmony.one>

# This is the commit message #11:

[node.sh] support -i shard_id option

-i shard_id             specify shard_id, this is applicable only to
explorer node

Signed-off-by: Leo Chen <leo@harmony.one>

# This is the commit message #12:

Revisited api

# This is the commit message #13:

Fix rpc integration

# This is the commit message #14:

address some minor issues in comments and code

# This is the commit message #15:

addressed comments on others' buckets

# This is the commit message #16:

Add Global Access to OS Temp Directory Variable and Move DHT Files Into Temp Directory
[cleanup] remove is_genesis flag

Signed-off-by: Leo Chen <leo@harmony.one>

[nodetype] add nodetype to replace is_explorer

Signed-off-by: Leo Chen <leo@harmony.one>

fix beacon sync channel blocking issue

use lastMileMux to protect lastMileBlock queue to avoid potential blocking; use sleep instead of ticker

Fix the beacon committee check

[release] add release action to go_executable_build.sh

Signed-off-by: Leo Chen <leo@harmony.one>

[node.sh] add -d option

-d              download only

Signed-off-by: Leo Chen <leo@harmony.one>

[node.sh] add -T node_type option

-T node_type       support node type (validator/explorer)

Signed-off-by: Leo Chen <leo@harmony.one>

[node.sh] backward compatible with older harmony binary

Signed-off-by: Leo Chen <leo@harmony.one>

[node.sh] support -i shard_id option

-i shard_id             specify shard_id, this is applicable only to
explorer node

Signed-off-by: Leo Chen <leo@harmony.one>

Revisited api

Fix rpc integration

address some minor issues in comments and code

addressed comments on others' buckets

Add Global Access to OS Temp Directory Variable and Move DHT Files Into Temp Directory

Add flag to disable signers

Fix explorer handler

Fix explorer handler

fix explorer for loop

add shardID information in getTransactionByHash RPC CALL

Add CXReceipt RPC call; Add indexing for CXReceipt by TxHash

use only one index for CXEntryLookup; use shardID instead of fromShardID in RPC returned results
@flicker-harmony flicker-harmony force-pushed the flicker-harmony:pr_merge_apis branch from 583aad0 to 809d77e Sep 17, 2019
@flicker-harmony

This comment has been minimized.

Copy link
Member Author

flicker-harmony commented Sep 17, 2019

Jenkins, test this please.

1 similar comment
@LeoHChen

This comment has been minimized.

Copy link
Contributor

LeoHChen commented Sep 17, 2019

Jenkins, test this please.

@LeoHChen LeoHChen merged commit 266a4e4 into harmony-one:master Sep 17, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Jenkins Build/Test Passed!
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.