Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the beacon committee check #1588

Merged
merged 1 commit into from Sep 13, 2019

Conversation

@harmony-ek
Copy link
Contributor

harmony-ek commented Sep 13, 2019

nodeconfig.Role no longer differentiates Leader from Validator, and at one point Leader role was removed. When we made that change, existing comparisons against Validator started holding true for leaders as well. This caused received beacon block broadcasts to be processed by beacon nodes themselves as well. However, the beaconchain syncing was disabled on beacon nodes, so attempts to send blocks over node.BeaconBlockChannel blocked, leading to leaks of goroutines created for processing incoming messages, then eventually to out-of-memory crashes.

@harmony-ek harmony-ek requested review from rlan35, denniswon, chaosma, LeoHChen and harmony-one/core Sep 13, 2019
@harmony-ek harmony-ek self-assigned this Sep 13, 2019
@denniswon

This comment has been minimized.

Copy link
Contributor

denniswon commented Sep 13, 2019

shipit! #hooleysheet @chaosma

@harmony-ek

This comment has been minimized.

Copy link
Contributor Author

harmony-ek commented Sep 13, 2019

Jenkins, test this please.

@harmony-ek harmony-ek merged commit 8ea1650 into harmony-one:master Sep 13, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
default Jenkins Build/Test Passed!
Details
@harmony-ek harmony-ek deleted the harmony-ek:beaconchain_sync_oom branch Sep 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.