Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log purge command #83

Merged
merged 5 commits into from Mar 12, 2018
Merged

Conversation

tonglil
Copy link
Contributor

@tonglil tonglil commented Feb 20, 2018

Need to test still, waiting for drone/drone-go#35.
If there is a way to test it without that merge, let me know.

Closes https://github.com/drone/drone-cli/issues/76.

@tonglil tonglil changed the title Log purge command Log purge command [WIP] Feb 20, 2018
@tonglil
Copy link
Contributor Author

tonglil commented Feb 20, 2018

PTAL @bradrydzewski

@tonglil
Copy link
Contributor Author

tonglil commented Feb 20, 2018

Do you need to tag a release of the Go library in order for this to use it?

@bradrydzewski
Copy link
Contributor

bradrydzewski commented Feb 20, 2018

You can add a revision constraint to the Gopkg.toml and then run dep ensure which should update the vendored dependencies.

We should definitely use tags, but I think we need to revisit the tagging strategy for drone-go and drone-cli. We were previously trying to use the same tags as drone/drone, but this is not working well in my opinion, since they follow different release schedules.

@tonglil tonglil changed the title Log purge command [WIP] Log purge command Feb 21, 2018
@tonglil
Copy link
Contributor Author

tonglil commented Feb 21, 2018

Alright, just built this locally and tested it, it was able to purge the logs.

image

Let me know if that toml file change is ok, or if you want me to pin to some commit sha.

@tonglil
Copy link
Contributor Author

tonglil commented Feb 21, 2018

^ build failure is due to outdated merge ref.

@bradrydzewski
Copy link
Contributor

@tonglil hey, sorry, looks like I might have caused a merge conflict when I updated to a newer version of drone-go. Can you update your PR and I can get this merged today? Thanks!!

@tonglil
Copy link
Contributor Author

tonglil commented Mar 12, 2018

Updated

@bradrydzewski
Copy link
Contributor

awesome, thanks again!

@bradrydzewski bradrydzewski merged commit 94a96d9 into harness:master Mar 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants