New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Phabricator remote integration #1499
Conversation
|
It still doesn;t really work is much more complicated. As nobody requested that I will close that for now. |
|
is there any suggested way on working with phabricator? I really appreciate the drone as well as phabricator and think a combination of both would be great! |
|
An phabricator remote driver must implement the interface defined at https://github.com/drone/drone/blob/master/remote/remote.go. I don't know how open brad is for new remote drivers or if he wants to enable an external service implementation instead of this. |
|
If you mean by external services that you can create some random web hook and drone kicks off - that would be great as well, I suppose. |
|
I would really like to be able to integrate Phabricator with Drone somehow. |
|
the steps required for phabricator integration are
no plans to implement on my end, but I would happily accept pull requests to the above two repositories. The login code should be straightforward, since it seems to have already been implemented by @tboerger in this closed pull request and just needs to be ported over. |
|
Cool, I might look into that after 0.9 comes out, then. |
|
@bradrydzewski I suppose should be https://github.com/drone/drone-scm |
|
oops, it is https://github.com/drone/go-scm |
This is currently work in progress. I have started to integrate phabricator as a remote into drone. The authentication already works, but now we need to find ways to add the other missing parts as well.
The client parts are taken from the Gitlab client.