Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not ignore Gitea TagHook #2966

Closed
wants to merge 2 commits into from
Closed

Do not ignore Gitea TagHook #2966

wants to merge 2 commits into from

Conversation

CirnoT
Copy link

@CirnoT CirnoT commented May 12, 2020

Gitea no longer sends push webhook for tag events, as per go-gitea/gitea#11082

@CLAassistant
Copy link

CLAassistant commented May 12, 2020

CLA assistant check
All committers have signed the CLA.

@ashwilliams1
Copy link
Contributor

Is this a breaking change from Gitea?

@CirnoT
Copy link
Author

CirnoT commented May 12, 2020

It was not an intention of that PR to introduce a breaking change, Drone just happened to rely on that behavior.

@ashwilliams1
Copy link
Contributor

ashwilliams1 commented May 13, 2020

It was not an intention of that PR to introduce a breaking change, Drone just happened to rely on that behavior.

The hook previously behaved the same as GitHub and GitLab, however, after the pull request was merged it no longer behaves in the same way. I feel like a pushing a tag should trigger a push event, the same way pushing a new branch triggers a push event (in addition to a branch create event). Are you sure this was not a regression? Was the intention for Gitea to behave differently than GitHub and GitLab?

It was not an intention of that PR to introduce a breaking change, Drone just happened to rely on that behavior.

This has been the behavior for years (since Gogs). Are you certain Drone is the only code that was relying on this behavior?

@lafriks
Copy link

lafriks commented May 13, 2020

Changes in Gitea has been reverted

@CirnoT
Copy link
Author

CirnoT commented May 13, 2020

Closing as per go-gitea/gitea#11397

@CirnoT CirnoT closed this May 13, 2020
@CirnoT CirnoT deleted the patch-1 branch May 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants