Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix image secrets in OSS version #3007

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

natlibfi-arlehiko
Copy link

This fixes the finding of image pull secrets in OSS version. The
relevant secrets are not found because Drone doesn't parse encrypted
secrets for the registry.

The bug is reported here: https://discourse.drone.io/t/pulling-private-images-not-working-in-oss-version/7594

This fixes the finding of image pull secrets in OSS version. The
relevant secrets are not found because Drone doesn't parse encrypted
secrets for the registry.

The bug is reported here: https://discourse.drone.io/t/pulling-private-images-not-working-in-oss-version/7594
@CLAassistant
Copy link

CLAassistant commented Aug 3, 2020

CLA assistant check
All committers have signed the CLA.

@natlibfi-arlehiko
Copy link
Author

What about this?

@tboerger tboerger requested a review from bradrydzewski Nov 22, 2020
Copy link

@Bdsjewelry Bdsjewelry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

plugin/registry/static.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants