Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(feat) redis implementation for pub-sub, log streaming and canceller #3108

Merged
merged 10 commits into from Aug 12, 2021

Conversation

marko-gacesa
Copy link
Contributor

@marko-gacesa marko-gacesa commented Jul 22, 2021

Introduces Redis as an optional dependency for Drone. If Redis connection string is defined, Drone will use Redis for pub-sub mechanism, log streaming and build canceller.

This PR is a part of HA push for Drone: To add support for several Drone servers to run in parallel.

@eoinmcafee00
Copy link

LGTM, I'd maybe also add to the description what this change solves and why?

@marko-gacesa marko-gacesa changed the title pubsub: redis implementation redis implementation for PubSub and LogStream interfaces Aug 2, 2021
@marko-gacesa marko-gacesa changed the title redis implementation for PubSub and LogStream interfaces (feat) implementation for PubSub and LogStream interfaces Aug 2, 2021
@marko-gacesa marko-gacesa changed the title (feat) implementation for PubSub and LogStream interfaces (feat) redis implementation for PubSub and LogStream interfaces Aug 2, 2021
@marko-gacesa marko-gacesa changed the title (feat) redis implementation for PubSub and LogStream interfaces (feat) redis implementation for pub-sub, log streaming and canceller Aug 2, 2021
@@ -166,6 +167,11 @@ type (
EnableAnonymousAccess bool `envconfig:"DRONE_PROMETHEUS_ANONYMOUS_ACCESS" default:"false"`
}

// Redis provides the redis configuration.
Redis struct {
ConnectionString string `envconfig:"DRONE_REDIS_CONNECTION"`
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend we also include redis username and database number as optional parameters. If someone is using hosted redis they may need to set these parameters https://github.com/go-redis/redis#quickstart

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants