Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: implemented gitee client #3156

Merged
merged 5 commits into from Nov 25, 2021

Conversation

kit101
Copy link

@kit101 kit101 commented Oct 13, 2021

implemented gitee client. https://gitee.com

require list:

  1. merge the drone/go-scm PR and tag
  2. create new tag github.com/drone/go-login ( dependent on github.com/drone/go-login/gitee )

@kit101 kit101 marked this pull request as draft October 29, 2021 05:17
@wmvm0
Copy link

wmvm0 commented Nov 17, 2021

请问一下,gitee 客户端工具怎么样了。是已经开发完成了吗。

@kit101
Copy link
Author

kit101 commented Nov 17, 2021

请问一下,gitee 客户端工具怎么样了。是已经开发完成了吗。

@Espoir999 开发完成了,PR还没合并

@wmvm0
Copy link

wmvm0 commented Nov 18, 2021

请问一下,gitee 客户端工具怎么样了。是已经开发完成了吗。

@Espoir999 开发完成了,PR还没合并

请问是经过测试了吗,大概多久之后能合并呢,jenkins 太重了,很期待支持gitee。

谢谢

@wmvm0
Copy link

wmvm0 commented Nov 18, 2021

请问一下,gitee 客户端工具怎么样了。是已经开发完成了吗。

@Espoir999 开发完成了,PR还没合并

兄弟,你这个Pr还在草案啊,貌似不能合并

@kit101
Copy link
Author

kit101 commented Nov 19, 2021

@Espoir999 你好
gitee客户端已经合并了,这个PR需要等待go-scm和go-login发布新版本并调整依赖项后才能被合并,而支持gitee的drone需要看社区的版本发布计划。

非常感谢你的期待!☺️

@kit101 kit101 changed the title WIP on implemented gitee client Feat: implemented gitee client Nov 22, 2021
@kit101 kit101 marked this pull request as ready for review November 22, 2021 13:13
@eoinmcafee00 eoinmcafee00 merged commit 2b77d96 into harness:master Nov 25, 2021
@wmvm0
Copy link

wmvm0 commented Nov 26, 2021

@Espoir999 你好 gitee客户端已经合并了,这个PR需要等待go-scm和go-login发布新版本并调整依赖项后才能被合并,而支持gitee的drone需要看社区的版本发布计划。

非常感谢你的期待!☺️

你好,我看着 drone 的文档部署 gitee 的 drone 服务出现了下面的问题,请问这是什么原因呢
image
这是我的 docker 命令
image

@eoinmcafee00
Copy link

eoinmcafee00 commented Nov 26, 2021

@Espoir999 I can see you are using version 2.0.0 You will need to pull latest. I haven’t done the official release of this integration yet.

@kit101 kit101 deleted the feature/gitee-client branch November 26, 2021 12:51
@kit101
Copy link
Author

kit101 commented Nov 26, 2021

@Espoir999 你好,支持gitee的版本和文档还未正式发布,请稍加等待。

@wmvm0
Copy link

wmvm0 commented Nov 26, 2021

@Espoir999 你好,支持gitee的版本和文档还未正式发布,请稍加等待。

好的

@wmvm0
Copy link

wmvm0 commented Nov 26, 2021

@Espoir999 I can see you are using version 2.0.0 You will need to pull latest. I haven’t done the official release of this integration yet.

ok

@wmvm0
Copy link

wmvm0 commented Dec 5, 2021

@Espoir999 你好,支持gitee的版本和文档还未正式发布,请稍加等待。
现在可以了吗,我运行runner 出现下图的报错信息,是我哪里没有配置吗?
image

@wmvm0
Copy link

wmvm0 commented Apr 27, 2022

implemented gitee client. https://gitee.com

require list:

  1. merge the drone/go-scm PR and tag
  2. create new tag github.com/drone/go-login ( dependent on github.com/drone/go-login/gitee )

哈喽,兄弟,gitee 的同步分页有个bug呀,默认情况下 opts := scm.ListOptions{Size: 100} ,所以默认 opts.Page = 0

opts := scm.ListOptions{Size: 100}
result, meta, err := s.client.Repositories.List(ctx, opts)

// gitee pageValues
populatePageValues(req, res)

// 第一次请求的时候,page = 0,所以 current = 0
current, currentError := strconv.Atoi(reqURL.Query().Get("page"))

没有走后面的分页逻辑
if current != 0 {
if current < resp.Page.Last {
resp.Page.Next = current + 1
} else {
resp.Page.Next = resp.Page.Last
}
if current > resp.Page.First {
resp.Page.Prev = current - 1
} else {
resp.Page.Prev = resp.Page.First
}
}

@wmvm0
Copy link

wmvm0 commented Apr 27, 2022

所以同步功能最多只能同步100个仓库

@kit101
Copy link
Author

kit101 commented Apr 28, 2022

@Espoir999 你好!已经提交了修复的PR,正在等待社区合并。
drone/go-smc#167

@wmvm0
Copy link

wmvm0 commented May 10, 2022

@Espoir999 你好!已经提交了修复的PR,正在等待社区合并。 drone/go-smc#167

好的,谢谢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants