Override drone build restart parameters #3182
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`drone build restart` never override the custom parameters set by cli if they are already present in the build: I.E. ``` $ drone build restart org/myrepo -p DOWNSTREAM_IMAGE_VER=test1 1 Number: 2 Status: pending Event: push [...] ``` In this case it works: `DOWNSTREAM_IMAGE_VER=test1` ``` $ drone build restart org/myrepo -p DOWNSTREAM_IMAGE_VER=test2 2 Number: 3 Status: pending Event: push [...] ``` In this case the variable test2 is ignored: `DOWNSTREAM_IMAGE_VER=test1` More detail about the issue: https://discourse.drone.io/t/issue-with-params-using-downstream-plugin/10418
|
Hi @asosso Can you please add a unit test for this? Cheers, |
|
|
|
What is the state of this PR? Can we expect a merge? We are also affected by this and could deliver an example where the downstream trigger does not behaves as expected. {"version":"2.11.1"} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
drone build restartnever override the custom parameters set by cli if they are already present in the build:I.E.
In this case it works:
DOWNSTREAM_IMAGE_VER=test1In this case the variable test2 is ignored:
DOWNSTREAM_IMAGE_VER=test1More detail about the issue: https://discourse.drone.io/t/issue-with-params-using-downstream-plugin/10418