From bcb126a6195f87a56af199f5ae6507d6f098a495 Mon Sep 17 00:00:00 2001 From: Dave Johnston Date: Thu, 19 May 2022 18:18:00 +0100 Subject: [PATCH] [FFM-3441]: Unable to evaluate JSON multivariate This change ensures we handle JSON types when evaluating with pre-reqs. Multivariate flags can contain JSON. This was missed from the current switch block. --- evaluation/feature.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/evaluation/feature.go b/evaluation/feature.go index 2fca6c6b..5a13b8c4 100644 --- a/evaluation/feature.go +++ b/evaluation/feature.go @@ -242,8 +242,10 @@ func (fc FeatureConfig) EvaluateWithPreReqFlags(target *Target, prereqFlags map[ reflect.Uint32, reflect.Uint64, reflect.Uint8: fallthrough case reflect.Float64, reflect.Float32: + fallthrough + case reflect.Map: variation, err = getVariationWithPrereqs(fc, target, prereqFlags) - case reflect.Map, reflect.Array, reflect.Chan, reflect.Complex128, reflect.Complex64, reflect.Func, reflect.Interface, + case reflect.Array, reflect.Chan, reflect.Complex128, reflect.Complex64, reflect.Func, reflect.Interface, reflect.Invalid, reflect.Ptr, reflect.Slice, reflect.Struct, reflect.Uintptr, reflect.UnsafePointer: err = fmt.Errorf("unexpected type: %s for flag %s", fc.GetKind().String(), fc.Feature) }