(FFM-5314) Optionally poll targets #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Story FFM-5314 · [Proxy] Config option to disable target polling |
conormurray95
force-pushed
the
FFM-5314-optionally-poll-targets
branch
from
927e6c0 to
a5f6b26
Compare
davejohnston
approved these changes
Nov 14, 2022
Contributor
davejohnston
left a comment
davejohnston
left a comment
There was a problem hiding this comment.
I like what you've done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Large numbers of targets can cause rate limiting issues, particularly when running multiple proxies. Here I'm adding the option to set this polling interval to 0 to disable fetching targets at all. Enabling this shouldn't impact any functionality and going forward we'll likely make 0 the default option in the next major release after we verify further it has no adverse affects.
Enabled this option for one set of our e2e tests to verify no errors are caused