FFM-3819/4402 - Update Go version, dependencies, point to ff-api config #68
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davejohnston
approved these changes
Sep 14, 2022
Contributor
davejohnston
left a comment
davejohnston
left a comment
There was a problem hiding this comment.
Provisionally this looks fine. Prior to releasing can we do a deploy into QA and make sure its continuing to function. I think it would be worth while testing a client side SDK along side a sever-side SDK against this.
…eature config type
stephenmcconkey
force-pushed
the
FFM-3819
branch
from
d6dee25 to
bf544af
Compare
conormurray95
approved these changes
Oct 6, 2022
Contributor
conormurray95
left a comment
conormurray95
left a comment
There was a problem hiding this comment.
LGTM! Tested offline mode and offline config generation too and all good
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
(This included creating additional methods for the cache, so we could use a common type between proxy and sdk (rest package over evaluation package))
Why
FFM-3819
FFM-4402
FFM-4572 - Implemented by updating to latest Go SDK which is essential for this to work
Testing
Updated Unit tests where applicable
Manual testing of Bool, Number, String, Json variations
Manual testing of PreReq, Targets, TargetGroup scenarios
^^ Pointed Golang SDK to Proxy to Prod 2 for these scenarios