(FFM-4588) Add config directory path parameter #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Linked to Story FFM-4588 · [Relay Proxy] Allow configurable config directory parameter |
conormurray95
force-pushed
the
FFM-4588-config-path-param
branch
from
7db689a to
51b332e
Compare
stephenmcconkey
approved these changes
Oct 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add an optional flag/environment variable that lets users specify their own config directory path. Previously this was baked in as /config which only worked for the containerised version.
Flag:
config-dirEnvironment variable:
CONFIG_DIRFixed a flaky unit test that's been in here for a while
Testing
Tested with: