(FFM-4654) Use ubuntu 20.04 image #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conormurray95
force-pushed
the
FFM-4654-use-ubuntu-20.04-image
branch
from
eb3bbc0 to
97ccc2e
Compare
|
✅ Linked to Bug FFM-4654 · [Proxy OS] Upgrade base image Ubantu 18.04 |
jcox250
approved these changes
Oct 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
To remove a load of vulnerabilities it has been recommended by the security team that we upgrade from ubuntu 18.04 to ubuntu 20.04
To do this I've taken the pushpin dockerfile here - https://github.com/fanout/docker-pushpin/blob/master/Dockerfile and changed it to build on ubuntu 20.04 instead.
Ideally we should build a pushpin 20.04 container that we can reference instead of building it within our dockerfile, however we first need to check that these changes have fixed our vulnerability issues. I've added a ticket to address this tech debt, i tried to add it to the pipeline but was refused permission publishing it to Dockerhub, will look into what I need to get to enable that additional image on there. Ticket for this enhancement here - https://harness.atlassian.net/browse/FFM-4816