(FFM-5106) Fix segments 404 error for client sdks #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conormurray95
changed the title
stephenmcconkey
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
If a client sdk connected to the proxy in in-memory mode and had no segments configured we'd return a 404 for the
/client/env/:environment_uuid/target/:target/evaluations/:feature endpointwhich is fetched when the client sdk is fetching an update for a specific flag.Fix
Like the other functions in this file if we receive a
ErrCacheNotFounderror we just log it and continue because segments aren't required configuration we need to evaluate the flag.