rms transformation functions: made more robust by checking ! length i…

…nstead of is.null; packaged up for CRAN
harrelfe · Sep 28, 2015 · a2a5bd9 · a2a5bd9
1 parent 1e78b89
commit a2a5bd9
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 1 deletion.
diff --git a/NEWS b/NEWS
@@ -18,6 +18,7 @@ Changes in version 4.4-0 (2015-09-28)
 	 * cph: added debug argument
 	 * tests/cph4.r: new tests for various predictor types
 	 * rms: changed warning to error if an ordered factor appears in the model and options(contrasts) is not set properly
+	 * rms transformation functions: made more robust by checking ! length instead of is.null
 
 Changes in version 4.3-1 (2015-04-20)
    * NAMESPACE: removed reference to gridExtra, in DESCRIPTION moved gridExtra from Depends to Suggests

diff --git a/tests/cph4.r b/tests/cph4.r
@@ -8,7 +8,6 @@ x3 <- runif(n)
 x4 <- sample(0:4, n, TRUE)
 x5 <- ordered(sample(1:3, n, TRUE), levels=1:3, labels=c('I','II','III'))
 S  <- Surv(runif(n))
-#source('~/R/rms/R/cph.s')
 f <- cph(S ~ x1 + pol(x2, 2) + rcs(x3, 4) + scored(x4) + x5)
 options(contrasts=c('contr.treatment', 'contr.treatment'))
 f <- cph(S ~ x1 + pol(x2, 2) + rcs(x3, 4) + scored(x4) + x5)