Jacob Harris harrisj

Organizations

@18F
harrisj opened pull request 18F/18f.gsa.gov#985
@harrisj
Edits to the bio for Jacob Harris
1 commit with 6 additions and 6 deletions
harrisj commented on issue 18F/myusa#678
@harrisj

Applied fix to Pull Request #685

@harrisj
  • @harrisj e1f8105
    Fix param_wrapper for tasks controller to include task_items_attributes
  • @harrisj 014f027
    Fixed test for POST to tasks to send an array of task_item hash
  • 1 more commit »
harrisj commented on issue 18F/myusa#678
@harrisj

Okay, I found why Rails is doing this. It's part of the normal behavior of wrap_parameters which we had enabled in an initializer: Also, if you've…

harrisj commented on issue 18F/myusa#678
@harrisj

I figured out the issue! The tests were posting JSON that looked like this {"tasks": {"name": "New Task", "url": "http://wwww.gsa.gov/", "task_item…

@harrisj
  • @harrisj 9c63d4a
    CI did not like my redundant use of a self prefix
@harrisj
Application UID/Secret generation should happen for blank fields
1 commit with 18 additions and 2 deletions
@harrisj
  • @harrisj 64a0f00
    Generate a secret and UID for the application if the field is blank (…
harrisj commented on issue 18F/myusa#678
@harrisj

@yoz, no idea yet why the tests work but my manual tests fail, but it's possible that it's an issue with how the tests are written. I wonder if the…

harrisj commented on issue 18F/myusa#623
@harrisj

The Consent screen settings for MyUSA in the Google Developers Console was pointing to a staging URL that was no longer there. Once @yozlet fixed t…

harrisj deleted branch feature/myusa_in_sender_field at 18F/myusa
harrisj pushed to devel at 18F/myusa
@harrisj
harrisj merged pull request 18F/myusa#645
@harrisj
Added MyUSA to reply_to field for emails.
1 commit with 1 addition and 1 deletion
harrisj commented on issue 18F/myusa#678
@harrisj

Currently this is passing its tests but it does not actually work when I attempt to do it manually. The nested attributes for task_items do not see…

harrisj commented on issue 18F/open-data-maker#14
@harrisj

We could also have the system automatically default to using a column named id or key or possibly name (that one might not always be unique) should…

harrisj commented on issue 18F/myusa#682
@harrisj

Assigning this to @yozlet to match pull request #684

harrisj opened issue 18F/myusa#696
@harrisj
Rake tasks to dump and load the database tables
harrisj closed issue 18F/myusa#646
@harrisj
Email address missing on access link re-send page
harrisj commented on issue 18F/myusa#646
@harrisj

Seeing this text now when testing on the devel branch: A new access link has been sent to your email address. Looks like this has been fixed.

harrisj reopened pull request 18F/myusa#645
@harrisj
Added MyUSA to reply_to field for emails.
1 commit with 1 addition and 1 deletion
harrisj commented on pull request 18F/myusa#645
@harrisj

:+1: here. I think it's good to merge

harrisj commented on issue 18F/myusa#675
@harrisj

One other consideration: the oauth_applications table is created by a migration within the Devise plugin, so it's probably ill-advised to significa…

harrisj commented on pull request 18F/myusa#638
@harrisj

:+1: if you are good to go, I am!

harrisj commented on pull request 18F/myusa#689
@harrisj

Okay, the hard tab should be fixed (shakes fist at text editor)

@harrisj
  • @harrisj 4e9164a
    Fixing an issue where a hard tab was inserted instead of spaces
harrisj commented on pull request 18F/myusa#638
@harrisj

I had to add a layout :redesign to the controller method to make it render correctly with the stylesheet. Do we want to rename the layout to have a…

@harrisj
  • @harrisj 5f2c563
    Add the redesign layout back to the authorizations controller
harrisj commented on pull request 18F/myusa#684
@harrisj

Technically, I fixed a problem that isn't necessarily going to happen again, but we might want to keep this monkey patch in there