New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow pending operations to be cancelled from front-end #42

Merged
merged 1 commit into from Oct 12, 2017

Conversation

Projects
None yet
2 participants
@duizendnegen
Contributor

duizendnegen commented Jul 22, 2017

This change allows cancelling pending operations, which could otherwise only be cancelled when they actually reached the running state. When no VM could be acquired or for other reasons the operation didn't start, there would be no sound way of cancelling those seemingly stuck tasks from the front-end.

@leehambley

This comment has been minimized.

Member

leehambley commented Jul 25, 2017

Hey @duizendnegen thanks for the PR, so simple life can be!

Can you please update this PR with a description/title, etc that fits the quality of the existing commit messages?

for example!

I know it seems mundane but I believe in a useful Git history (sometimes I think I might be the only person in the universe who sees the Git log as the 2rd dimension in understanding code!)

@duizendnegen duizendnegen changed the title from Allow pending cancellations to Allow pending operations to be cancelled from front-end Jul 25, 2017

Allow pending operations to be cancelled from front-end
This change allows cancelling pending operations, which could otherwise
only be cancelled when they actually reached the running state. When no
VM could be acquired or for other reasons the operation didn't start,
there would be no sound way of cancelling those seemingly stuck tasks
from the front-end.
@duizendnegen

This comment has been minimized.

Contributor

duizendnegen commented Jul 25, 2017

Done @leehambley - in both the PR and the commit. Not sure what exactly to write, since no new methods are uncovered or API is exposed.

(Edit: you're not the only one, I am a heavy user of git blame and reading commit messages to figure out why things entered the code in the first place. My favourite reason is "did things, fixed stuff")

@leehambley leehambley merged commit 6e254ef into harrowio:master Oct 12, 2017

1 check passed

license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment