Skip to content

test: Add tests for push#614

Merged
harttle merged 5 commits intoharttle:masterfrom
TomasHubelbauer:tom/push-tests
May 29, 2023
Merged

test: Add tests for push#614
harttle merged 5 commits intoharttle:masterfrom
TomasHubelbauer:tom/push-tests

Conversation

@TomasHubelbauer
Copy link
Contributor

@TomasHubelbauer TomasHubelbauer commented May 25, 2023

I thought push was broken because it doesn't work on the Playground but that's not the case. Here are the tests to prove it. Taken from the concat tests.

Related to #611

See https://jekyllrb.com/docs/liquid/filters

I am sorting the array randomly and then picking the first N items or all items if there is no sample limit.
I thought `push` was broken because it doesn't work on the Playground but that's not the case. Here are the tests to prove it. Taken from the `concat` tests.
This got in from another branch lol.
This one works for me locally whereas build:docs is reporting some issues.
@TomasHubelbauer TomasHubelbauer requested a review from harttle May 28, 2023 18:26
…o workshop the message

I am working on a PR to make `build` run on macOS because it is a part of the pre-commit hook anyway so all contributors should make it work for them.

I have also shown how to check your messages against `commitlint` from the CLI because it is faster than using the VS Code GUI.
@harttle harttle merged commit db67118 into harttle:master May 29, 2023
@TomasHubelbauer TomasHubelbauer deleted the tom/push-tests branch May 29, 2023 16:08
@github-actions
Copy link

github-actions bot commented Jun 3, 2023

🎉 This PR is included in version 10.8.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants