doc: update the steps of customize the default StorageClass#488
Merged
bk201 merged 1 commit intoJan 29, 2024
Merged
Conversation
Collaborator
✅ Deploy Preview for harvester-preview ready!
|
Contributor
jillian-maroket
left a comment
jillian-maroket
left a comment
There was a problem hiding this comment.
@Vicente-Cheng I changed the structure of the procedure and reworded some of the steps to match the expected user behavior. Let me know if you have concerns.
Vicente-Cheng
force-pushed
the
add-doc-for-custom-default-sc
branch
from
60a0170 to
b5bf4da
Compare
jillian-maroket
approved these changes
Dec 12, 2023
Signed-off-by: Vicente Cheng <vicente.cheng@suse.com> Co-authored-by: Jillian <cjmaroket@outlook.com>
Vicente-Cheng
force-pushed
the
add-doc-for-custom-default-sc
branch
from
b5bf4da to
85c9a67
Compare
Contributor
Author
|
After the review is complete, I will copy this improvement to v1.1 and v1.2. |
bk201
approved these changes
Jan 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related issue: harvester/harvester#4045