[Feature] Keeping classes of the options #30

Closed
stof opened this Issue Jul 21, 2011 · 6 comments

Comments

Projects
None yet
3 participants
@stof
Collaborator

stof commented Jul 21, 2011

I would like being able to add a class on some <option> items of the HTML select list and have them added to the <li> item of the list created by the plugin when using it to enhance the form as I need to be able to style some options in a specific way.

None of the plugin I found to enhance select lists support it currently. Your plugin seems really good and I consider using it so I would love if it supports this feature.

@pfiller

This comment has been minimized.

Show comment Hide comment
@pfiller

pfiller Jul 26, 2011

Contributor

I think this may be viable, but will need to test performance when looping over 100's of options before committing.

Contributor

pfiller commented Jul 26, 2011

I think this may be viable, but will need to test performance when looping over 100's of options before committing.

@stof

This comment has been minimized.

Show comment Hide comment
@stof

stof Jul 26, 2011

Collaborator

you could make it configurable (at least for the jQuery plugin where it is common to provide options when using them. I never used prototype to know how it works). This way, it could be activated only when the user need it to have better performances.

Collaborator

stof commented Jul 26, 2011

you could make it configurable (at least for the jQuery plugin where it is common to provide options when using them. I never used prototype to know how it works). This way, it could be activated only when the user need it to have better performances.

@pfiller

This comment has been minimized.

Show comment Hide comment
@pfiller

pfiller Sep 29, 2011

Contributor

I was unable to detect a noticeable performance hit on a select with thousands of options. As of 7dd2908, Chosen retains the original form element's options.

Contributor

pfiller commented Sep 29, 2011

I was unable to detect a noticeable performance hit on a select with thousands of options. As of 7dd2908, Chosen retains the original form element's options.

@pfiller pfiller closed this Sep 29, 2011

@stof

This comment has been minimized.

Show comment Hide comment
@stof

stof Sep 29, 2011

Collaborator

thanks

Collaborator

stof commented Sep 29, 2011

thanks

pfiller added a commit that referenced this issue Sep 30, 2011

Up version number to 0.9.5
- Allow disabling of Search on single select boxes with <= N options (#45).
- Retain original option styles
- Retain original option classes (#30)
- Fix show results bug when clicking close icon (#277)
@mdi

This comment has been minimized.

Show comment Hide comment
@mdi

mdi Oct 4, 2011

How about inheriting a select's class and title attributes? e.g. for adding a tooltip to a select.

mdi commented Oct 4, 2011

How about inheriting a select's class and title attributes? e.g. for adding a tooltip to a select.

@pfiller

This comment has been minimized.

Show comment Hide comment
@pfiller

pfiller Oct 4, 2011

Contributor

@mdi That is covered in a different feature request (#209)

Contributor

pfiller commented Oct 4, 2011

@mdi That is covered in a different feature request (#209)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment