Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Esc key propagation stopped by implied return #390

Closed
mikefrey opened this Issue Dec 9, 2011 · 1 comment

Comments

Projects
None yet
2 participants
Contributor

mikefrey commented Dec 9, 2011

Since coffeescript makes the last line of any code path a return statement, the commit at the below url is stopping propagation of the key up event when the ESC key is pressed.

A return true statement should be added below the call to results_hide

db9fd24

Contributor

pfiller commented Jan 12, 2012

Resolved when #391 was merged in.

@pfiller pfiller closed this Jan 12, 2012

@mikeusry mikeusry pushed a commit to mikeusry/banyantree that referenced this issue Jul 14, 2015

@mikefrey mikefrey Fixed: Esc key propagation stopped by implied return a316ca8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment