One line change to .coffee and build and many diffs in generated js #404

Closed
marknadig opened this Issue Dec 16, 2011 · 1 comment

Comments

Projects
None yet
2 participants
@marknadig
Contributor

marknadig commented Dec 16, 2011

I forked the repo, installed coffee script (1.1.3) and ugliffy, applied a one-line fix to chosen.jquery.coffee and proto.coffee file and rebuilt. Comparing the uncompressed chosen.jquery.js and proto.js shows many non-whitespace diffs. I'm assuming this is related to different versions of coffeescript when built. Should I care? Should I commit the generated js or just the .coffee files for pull request?

Thanks!
Mark

@pfiller

This comment has been minimized.

Show comment
Hide comment
@pfiller

pfiller Jan 12, 2012

Contributor

I don't see a need to be too worried about whitespace mismatches in pull requests just yet. It's obviously not ideal, but since the important change is happening in the coffeescript file, it's not a huge problem.

Ideally, we wouldn't even need to commit the javascript files (they'd just be generated by the build system), but I suspect usage would drop heavily in that case.

Thanks for looking out.

Contributor

pfiller commented Jan 12, 2012

I don't see a need to be too worried about whitespace mismatches in pull requests just yet. It's obviously not ideal, but since the important change is happening in the coffeescript file, it's not a huge problem.

Ideally, we wouldn't even need to commit the javascript files (they'd just be generated by the build system), but I suspect usage would drop heavily in that case.

Thanks for looking out.

@pfiller pfiller closed this Jan 12, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment