Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove use of attr(), closes #334 #1385

Merged
merged 7 commits into from Jul 24, 2013
Merged

Conversation

koenpunt
Copy link
Collaborator

No description provided.

Fixes:
- issues with content security policy (harvesthq#1215)
- onbeforeunload in IE (harvesthq#403)

We don't need to add a preventDefault because all clicks on
.chzn-container already have a preventDefault
ti = @form_field_jq.attr "tabindex"
@form_field_jq.attr "tabindex", -1
@search_field.attr "tabindex", ti
if @form_field_jq[0].tabIndex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can replace all your @form_field_jq[0] references with @form_field which is a native select reference.

@koenpunt
Copy link
Collaborator Author

@pfiller I've merged your branch #1377 as the change of the cursor: pointer has to be there for both of us.

@pfiller
Copy link
Contributor

pfiller commented Jul 24, 2013

Cool cool cool. As best I can tell, this is working great. Pulling the trigger!

pfiller added a commit that referenced this pull request Jul 24, 2013
Remove javascript:void and attr references
@pfiller pfiller merged commit 8ae0c09 into harvesthq:master Jul 24, 2013
@koenpunt koenpunt deleted the remove-attr branch July 24, 2013 21:38
pfiller added a commit that referenced this pull request Jul 26, 2013
- CSS Updates #1368, #1371
- Prevent text selection on Chosen #1374
- single_backstroke_delete defaults to true #1375
- No longer expose classes to window context #1389
- Single select value fix #1392
- Remove javascript:void and attr references #1385, #1377
- Disable Chosen on iPhone / iPod and Android mobile devices
  by default #1388
- Add Destroy Method #1396
- Option to Hide Selected & Disabled Options #1404
- Always clear result highlight #1407
- Replace characters only once #1411

- Document all the things. #1366, #1376, #1383
- Add Gemfile for compass dependency #1373
- Update copyright and license link #1397
- Add @koenpunt as a maintainer #1399
- Add anchors to documentation headers #1395
- Updated stackoverflow instructions #1403
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants