Make results_search run after keyup of Cmd key #2702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of a known behaviour in OSX, Cmd-Delete only registers a single keyup (that of Cmd). Because the results_search function was blocked from running on keyup of Cmd, the "no matching results" message continued to be displayed.
|
Thanks! However I think the issue can also be solved by listening to the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This is a fix for #2521
Because of a known behaviour on OSX,
keyupevents are not triggered for a key pressed while Cmd is being held down.This lead to an issue when pushing Cmd-Delete on Mac to clear the search field. The
keyupevent handler ignores any pushes of (amongst others) modifier keys, including Ctrl, Alt, and Cmd.This commit simply lets the search function continue to run after Cmd is released, so behaviour is closer to expected.
References