Add support for labels #564

Closed
wants to merge 3 commits into
from

Projects

None yet

6 participants

@matflores
Contributor

These commits add support for labels associated with the original select control, fixing issue #257.

For standard select controls, the chosen field gains focus when the label is clicked.
For multiple select controls, the chosen field gains focus and the results drop-down list becomes visible when the label is clicked.

Collaborator
stof commented Apr 5, 2012

@matflores the changes in the compiled files look weird. Did you use the task in the Cakefile to build them or a custom way ?

Contributor

@stof I used the cake build task, but had an old version of coffee installed. I've just regenerated everything with v1.2.0.

peschee commented Jun 1, 2012

Any chance this gets merged to master?

@peschee peschee added a commit to peschee/chosen that referenced this pull request Jun 8, 2012
@peschee peschee Added PR #564 683dc2b
ericbock commented Jul 2, 2012

I'd be happy seeing this pulled into chosen. However, it does miss the case where a label wraps its input:

<label>Full name: <input name=fn></label>

Do you think it's worth accounting for?

I for one would love to see this worked into the master (as well as ericbock's comment just above).

I'm also really baffled why I'm not able to simulate this behavior using the custom events, e.g. here: http://brokendisk.com/code/chosen/index.html

@pfiller pfiller referenced this pull request Apr 18, 2013
Merged

Add support for labels #1152

Contributor
pfiller commented Apr 18, 2013

@matflores Thanks for this - it's nice. I've opened a new pull request with your commits #1152 (had to merge the latest master in). Wondering if we should also build to support the label around field type. Feel free to weigh in there.

@pfiller pfiller closed this Apr 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment