Add option classes to 'search-choice' element #580

wants to merge 2 commits into


None yet

3 participants


No description provided.


Changes must be done in the CoffeeScript source, not in the compiled JS code (as the next compilation would loose it). And according to the readme, contributions are accepted only if they update both the jQuery and the Prototype implementations

@roparz roparz Add option classes to 'search-choice' element (bis-repetita)
Remove changes from js file and apply them into coffee files.

All done.


I think this could introduce a lot of issues where people add classes to a search result and don't expect it to propagate to the displayed search choices. I haven't seen a lot of demand for this, but if it were something that got added, it would ideally be behind an optional parameter or take advantage of an appropriately named data attribute.

Thanks anyways, @roparz

@pfiller pfiller closed this Apr 23, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment