Ported CSS to LESS #690

Closed
wants to merge 2 commits into from

3 participants

@ghepting

ported CSS file to LESS and added LESS formatted stylesheet

@cmjacques

This is great - thanks!
Would be a great improvement if you used variables for the colours, gradients and image paths. :)

@ghepting

I've completed the initial sweep through adding vars and mixins -- we might want to come up with a strategy for the variable naming conventions -- it could prove to be a lot more intuitive if the var names describe what elements they are applied to, rather than what the color is, I'll leave that up to you for now. Might spend some more time on it down the road.

@stof stof commented on the diff Sep 3, 2012
chosen/chosen.less
+@grayLightest: #eee;
+@grayLighter: #e4e4e4;
+@grayLight: #d4d4d4;
+@gray2: #999;
+@gray: #aaa;
+@grayDark2: #444;
+@grayDark: #666;
+@grayDarker: #333;
+@grayDarkest: #111;
+@blue: #3875d7;
+@blueLight: #5897fb;
+@blueDark: #2a62bc;
+@shadow: rgba(0,0,0,.3);
+@softShadow: rgba(0,0,0,0.1);
+@softestShadow: rgba(0,0,0,0.05);
+@sprite: url('/js/libs/chosen/chosen-sprite.png');
@stof
stof added a note Sep 3, 2012

the url of the sprite is wrong IMO

@yaycmyk
yaycmyk added a note Nov 28, 2012

Probably should have .. in front of the first /

@stof
stof added a note Nov 28, 2012

well, t has no reason to contain /js/libs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@pfiller

Thanks for doing this @ghepting.

There's been a lot of CSS divergence since this PR initially opened. I think I'd also like any change to LESS (or SASS) to be accompanied by a change in build sytem (like #1103 does). Gonna close this one.

@pfiller pfiller closed this Apr 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment