`strip_text` sizing in `facet_wrap` is off

[jbloom]

The sizing of the strips with the labels above the plots in facet_wrap is inconsistent. If I facet_wrap a plot with just two rows, I get what seem to me to be overly narrow strips such that the label text is at the edges of the strip.

I can increase the strip height with + theme(strip_text=element_text(lineheight=1.8)). But then the strips become far too tall when there are more rows in the faceted plot.

I have played around with this some, and I think the ultimate problem is that the way that the height of the strip text is computed must depend on the total height of the faceted plots, such that plots with more rows end up with taller strip texts.

Let me know if you want me to post example images.

[jbloom]

The same phenomenon also applies to the vertical spacing between the facet rows -- as the overall plot gets taller (more rows), the spacing between the rows also gets relatively larger.

[has2k1]

You have come across a very hairy [1] part of the package. However, I recall making sure that you can at least get consistent spacing. Please do include plots, I may be able to give a precise solution.

[1] The underlying issue is a lack of a layout manager

[jbloom]

Hi Hassan,

Thanks for the quick reply. I have attached examples of two plots generated by identical code except that one is faceted over more samples, and so has more rows. As you can see, the height of the strip goes from too small in the first attachment to too large in the second one.

Here is the code that generates these plots: https://github.com/jbloomlab/dms_tools2/blob/master/dms_tools2/plot.py#L290-L304

The underlying dataframe is a bit complex so I'm not including that, but I can make a toy example that gives the same problem on a simpler toy data frame if that is helpful -- just let me know.

Thanks,
Jesse

[has2k1]

That does not look good, I expect consistent margins (top, bottom) around the strip_text. A simpler example would be helpful.

I'm wondering if this

...
+ theme(figure_size=(2.25 * (0.6 + ncol), 1.3 * (0.3 + nrow)))
)
p.save(plotfile)

would give a better plots.

[jbloom]

Your suggestion was a good one. The problem exists when the plot size is set via save but not when it is set by theme(figure_size=(x, y)).

The following attachment has a Jupyter notebook (and HTML rendering) that
plotnine_facet_wrap.zip
illustrates this on a toy example.

I'm not sure if this would still be considered a bug (you could argue that maybe the strips should be right regardless of how the figure size is set), but this certainly fixes my problem from a practical perspective!

Thanks so much for the help, and feel free to close the issue if you'd like.

[has2k1]

Great. Yes, it is still a bug.