Skip to content

stat_summary_bin no default summary function #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
keatingw opened this issue Sep 9, 2021 · 0 comments
Closed

stat_summary_bin no default summary function #528

keatingw opened this issue Sep 9, 2021 · 0 comments

Comments

@keatingw
Copy link

keatingw commented Sep 9, 2021

First off, thanks so much for this project - an implementation of ggplot2 in python is absolutely amazing.

I noticed that stat_summary_bin does not have a summary function set by default, raising a PlotnineError 'No summary function'. This seems to run contrary to its docstring stating that "mean_cl_boot" is the default. When using stat_summary the stated behaviour is used.

Having a quick glance at the source code it seems like this is just the matter of setting the default 'fun_data' to None in line 92 of stat_summary_bin.py.

Not a problem if this behaviour is intentional to force the user selection, though it may be best to adjust the docstring in this case.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants