Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate .html jinja templates #166

Closed
vidya-ram opened this issue Oct 9, 2017 · 3 comments
Closed

Deprecate .html jinja templates #166

vidya-ram opened this issue Oct 9, 2017 · 3 comments

Comments

@vidya-ram
Copy link
Member

vidya-ram commented Oct 9, 2017

As part of Baseframe PR #164, new .html.jinja2 templates have been added. The old templates (.html), now simply consist of {% extends "<name>.html.jinja2" -%} To deprecate the old .html templates, references to these templates (baseframe.html, formlayout.html, layout.html, baseframe/components.html, baseframe/forms.html, baseframe/networkbar.html) have to be updated in all HasGeek apps.

vidya-ram added a commit to hasgeek/eventframe that referenced this issue Oct 12, 2017
hasgeek/baseframe#166)
2. Rename all app templates to use .html.jinja2 extension
@jace
Copy link
Member

jace commented Oct 16, 2017

@vidya-ram @iambibhas last two repos pending.

@iambibhas
Copy link
Contributor

@jace @vidya-ram only eventframe remaining. but seems like it'll stay open for sometime.

@jace
Copy link
Member

jace commented Oct 16, 2017

Eventframe websites are distinct from Eventframe project repo. Latter can migrate and close independently.

@jace jace closed this as completed Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants