Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rel=nofollow on proposal comments #413

Closed
captn3m0 opened this issue May 14, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@captn3m0
Copy link

commented May 14, 2019

Old proposals receive a lot of spam: https://hasgeek.com/50p/2018/proposals/the-secret-life-of-bank-codes-awBCMUFMW3zqqXERGtngGR

Setting a rel=nofollow noindex attribute should dis-incentivize spammers from doing this.

@jace

This comment has been minimized.

Copy link
Member

commented May 15, 2019

@captn3m0 nofollow will be added to links in all new comments once hasgeek/coaster#226 is merged. We'll have to manually recompile existing comments since we cache them in the db.

Should we add noindex as well?

@jace

This comment has been minimized.

Copy link
Member

commented May 15, 2019

It appears noindex only applies in the <meta> tag, not in <a> tags.

@captn3m0

This comment has been minimized.

Copy link
Author

commented May 15, 2019

Yeah, just nofollow should be enough.

@jace

This comment has been minimized.

Copy link
Member

commented May 15, 2019

Dependency is merged. Deployment and migration to follow.

@jace

This comment has been minimized.

Copy link
Member

commented May 16, 2019

Done. All links in comments now have rel="nofollow". We still need to remove the spam comments and add better filters, which I'll track in #412.

@jace jace closed this May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.