New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update config to support 4.x options #144

Open
wants to merge 2 commits into
base: master
from

Conversation

Projects
None yet
3 participants
@drGrove
Member

drGrove commented Oct 4, 2018

No description provided.

@drGrove drGrove requested review from lrvick, RyanSquared and KellerFuchs Oct 4, 2018

@drGrove drGrove referenced this pull request Oct 4, 2018

Open

Upgrade to 4.2.0 #13

@drGrove

This comment has been minimized.

Show comment
Hide comment
@drGrove

drGrove Oct 4, 2018

Member

Needs hashbang/docker-unrealircd#13. I'm also not sure of a good way to test all of this. Any pointers would be appreciated prior to us merging

Member

drGrove commented Oct 4, 2018

Needs hashbang/docker-unrealircd#13. I'm also not sure of a good way to test all of this. Any pointers would be appreciated prior to us merging

@RyanSquared

This comment has been minimized.

Show comment
Hide comment
@RyanSquared

RyanSquared Oct 4, 2018

Contributor

@drGrove with testing, you should be able to set up a VM - or even change the Ansible target to your own system - and run the IRCd locally.

Contributor

RyanSquared commented Oct 4, 2018

@drGrove with testing, you should be able to set up a VM - or even change the Ansible target to your own system - and run the IRCd locally.

@RyanSquared

This comment has been minimized.

Show comment
Hide comment
@RyanSquared

RyanSquared Oct 4, 2018

Contributor

I can't test it myself right now, I'll try to do so over the weekend.

Contributor

RyanSquared commented Oct 4, 2018

I can't test it myself right now, I'll try to do so over the weekend.

@drGrove

This comment has been minimized.

Show comment
Hide comment
@drGrove

drGrove Oct 4, 2018

Member
Member

drGrove commented Oct 4, 2018

@RyanSquared

This comment has been minimized.

Show comment
Hide comment
@RyanSquared

RyanSquared Oct 4, 2018

Contributor

Does ansible have a local runner

ansible-playbook -i localhost, instead of just ansible-playbook, but I'm not entirely sure how well it would work on a user system because we hardcode in some file paths which might not exist (like /home/core)?

Contributor

RyanSquared commented Oct 4, 2018

Does ansible have a local runner

ansible-playbook -i localhost, instead of just ansible-playbook, but I'm not entirely sure how well it would work on a user system because we hardcode in some file paths which might not exist (like /home/core)?

@RyanSquared

This comment has been minimized.

Show comment
Hide comment
@RyanSquared

RyanSquared Oct 4, 2018

Contributor

Ansible also has {{ ansible_env.HOME }} which as I understand, means the $HOME var for the current user.

Contributor

RyanSquared commented Oct 4, 2018

Ansible also has {{ ansible_env.HOME }} which as I understand, means the $HOME var for the current user.

@benharri

This comment has been minimized.

Show comment
Hide comment
@benharri

benharri Oct 4, 2018

Member

you could also spin up a lxd or docker container on a stretch image and run it against that

Member

benharri commented Oct 4, 2018

you could also spin up a lxd or docker container on a stretch image and run it against that

Move to sync, update conf files to 4.x
Move from copy to sync to allow for recursive copy
Update conf files to 4.x
Move to ansbile_env.HOME

@drGrove drGrove requested a review from benharri Oct 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment