Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

10.0 #3

Merged
merged 8 commits into from Sep 15, 2019

Conversation

@lrvick
Copy link
Member

commented Sep 10, 2019

Refactor and initial support for 10.0

lrvick added 3 commits Sep 9, 2019

@lrvick lrvick force-pushed the 10.0 branch from 571418c to aba714c Sep 10, 2019

lrvick added 2 commits Sep 11, 2019
Makefile Outdated
@$(contain) tools

.PHONY: random
random:
test -f $(PWD)/build/.rnd || head -c 1G </dev/urandom > $(PWD)/build/.rnd

This comment has been minimized.

Copy link
@drGrove

drGrove Sep 11, 2019

Member

< /dev/urandom

This was annoying me earlier

config.yml Outdated
extra_remotes:
- name: github
fetch: https://github.com
extra_projects:
- name: anestisb/android-prepare-vendor
- name: RattlesnakeOS/android-prepare-vendor

This comment has been minimized.

Copy link
@drGrove

drGrove Sep 11, 2019

Member

Why RattlesnakeOS?

This comment has been minimized.

Copy link
@lrvick

lrvick Sep 11, 2019

Author Member

their fork is the only one with 10 support atm.

cat <<-EOF | bash
export OUT_DIR="${kernel_dir}/out"
export DIST_DIR="${kernel_dir}/dist"
bash "${kernel_dir}/build/build.sh" -j$(cores)
bash "${kernel_dir}/build/build.sh" -j "$cores"

This comment has been minimized.

Copy link
@drGrove

drGrove Sep 11, 2019

Member

"${cores}"

This comment has been minimized.

Copy link
@lrvick

lrvick Sep 11, 2019

Author Member

ha. good catch. no wonder that was not working

# Chromium
if [ "$build_chromium" == "true" ]; then
[ ! -d "$chromium_dir/depot_tools" ] && \
git clone "${chromium_build_tools_url}" "$chromium_dir/depot_tools"

This comment has been minimized.

Copy link
@drGrove

drGrove Sep 11, 2019

Member

${chromium_dir}

git clone "${chromium_build_tools_url}" "$chromium_dir/depot_tools"
cd "$chromium_dir/depot_tools"
git fetch
git reset --hard "$chromium_depot_tools_ref"

This comment has been minimized.

Copy link
@drGrove

drGrove Sep 11, 2019

Member

${chromium_depot_tools_ref}

git fetch
git reset --hard "$chromium_depot_tools_ref"

export PATH="$PATH:$chromium_dir/depot_tools"

This comment has been minimized.

Copy link
@drGrove

drGrove Sep 11, 2019

Member

This is not consistent, wrap env vars in {}

kernel_name = config['devices'][device]['kernel_name']
repo = "kernel/manifest"
ref = config['devices'][device]['kernel_ref']
filename = '%s/kernel-%s.xml' % (path, kernel_name)

This comment has been minimized.

Copy link
@drGrove

drGrove Sep 11, 2019

Member

Move to using .format() instead

lrvick added 3 commits Sep 11, 2019
@lrvick

This comment has been minimized.

Copy link
Member Author

commented Sep 14, 2019

@drGrove Just tested on my taimen. Everything works.

@drGrove drGrove merged commit ca45241 into master Sep 15, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.