Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machine abstraction #5

Merged
merged 68 commits into from Dec 1, 2019
Merged

Machine abstraction #5

merged 68 commits into from Dec 1, 2019

Conversation

@lrvick
Copy link
Member

lrvick commented Sep 22, 2019

Changed

  • refactors container to install fixed versions of apt packages to be more deterministic
  • Adds docker-machine backend allowing one to select "local" "digitalocean" or "virtualbox" backends with ability to easily add more in the future.
  • Include cloud management tooling for future cloud backends and setup pattern to hash lock them
  • Refactor paths to deal with different mounting needs of remote vs local so that:
    • all configuration ends up in a single "config" tree downstreams can override
    • all downloaded sources and build cache lives in top level 'build' directory
    • all output goes to top level release directory

TODO

  • test digitalocean build support
  • document new backends and how to select them
  • automatically download/cache docker-machine binary with wrapper script
lrvick added 11 commits Aug 26, 2019
…for future
@lrvick lrvick requested a review from drGrove Sep 22, 2019
Makefile Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
scripts/environment Outdated Show resolved Hide resolved
scripts/environment Outdated Show resolved Hide resolved
scripts/environment Outdated Show resolved Hide resolved
lrvick and others added 16 commits Sep 23, 2019
…ig and add mechanism to auto update
…into RattlesnakeOS-updates
ypid and others added 9 commits Nov 10, 2019
Ref: sargo-QP1A.191105.003-factory-267092f1.zip
…aosp-build into ypid-machine-abstraction-rework
…ases for now
ypid added 4 commits Nov 14, 2019
Revert "[scripts/release] Drop Pixel 1 support"

This reverts commit e1bdece.
@ypid ypid mentioned this pull request Nov 17, 2019
ypid added 4 commits Nov 17, 2019
warning: -f/--force-broken is now the default behavior, and the options are deprecated
The issue was that repo sync failed in my case so I build images which
where not in alliance with base.xml.
@ypid

This comment has been minimized.

Copy link
Contributor

ypid commented Nov 23, 2019

cc: @lsfxz you might also be interested in the work that Hashbang OS is doing (ref: https://github.com/lsfxz/AOSP-Build-Environment-Docker).

I also informed @Trumeet in Trumeet/AOSP-Build-Environment-Docker#3.

ypid and others added 3 commits Nov 23, 2019
Example log line:

```
+ 2019-11-17 17:49:34+00:00 make -j 2 target-files-package brillo_update_payload
```
@lrvick

This comment has been minimized.

Copy link
Member Author

lrvick commented Nov 27, 2019

@drGrove Considering the Android 9 setup is no longer updated and has known CVEs I think we should just do a hard cut to this into master at this point given that it has been tested by myself and ypid.

We keep merging PRs into this branch and it might as well be master at this point.

Thoughts?

@lrvick

This comment has been minimized.

Copy link
Member Author

lrvick commented Nov 27, 2019

@drGrove addressed all your comments in last commit

@lrvick lrvick requested a review from drGrove Nov 27, 2019
@drGrove
drGrove approved these changes Dec 1, 2019
@drGrove drGrove merged commit 27d3ade into master Dec 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.