New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In build_plain() in Straight/Combi/Hybrid mode no need for clEnqueReadBuffer #1607

Open
RobotGF opened this Issue Jul 6, 2018 · 1 comment

Comments

Projects
None yet
2 participants
@RobotGF

RobotGF commented Jul 6, 2018

CL_rc = hc_clEnqueueReadBuffer (hashcat_ctx, device_param->command_queue, device_param->d_pws_idx, CL_TRUE, gidd * sizeof (pw_idx_t), sizeof (pw_idx_t), &pw_idx, 0, NULL, NULL);

if (CL_rc == -1) return -1;
  

if (cnt > 0)
{
   CL_rc = hc_clEnqueueReadBuffer (hashcat_ctx, device_param->command_queue, device_param->d_pws_comp_buf, CL_TRUE, off * sizeof (u32), cnt * sizeof (u32), pw->i, 0, NULL, NULL);

  if (CL_rc == -1) return -1;
}

In opencl.c gidd_to_pw_t() I think there is no need for data transfer. We can use the host data straightly
like this:

pw_idx=device_param->pws_idx[gidd];

memcpy(pw->i,device_param->pws_comp+off,cnt*sizeof(u32));
@jsteube

This comment has been minimized.

Member

jsteube commented Jul 6, 2018

You can try using your code by using this branch selection:

user_options_extra_t *user_options_extra = hashcat_ctx->user_options_extra;

if (user_options_extra->attack_kern == ATTACK_KERN_COMBI)
{
... your code
}
else
{
... existing code
}

Add some test cases and send in a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment