New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Invalid masks accepted #1708

Closed
s3inlc opened this Issue Oct 1, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@s3inlc

s3inlc commented Oct 1, 2018

When running attack mode 3 and giving a mask with having a question mark at the end, e.g. ?1?2?3?, hashcat accepts it and runs the attack, just ignoring the question mark at the end (so just three bytes in the case of the example). But on the status it shows something different: Guess.Mask.......: ?1?2?3? [4]

Such a mask should just be rejected because a question mark alone is not valid for a mask, either it needs a char to define a charset or another question mark if this should be just the single char.

@jsteube jsteube closed this in b146569 Oct 16, 2018

jsteube added a commit that referenced this issue Oct 16, 2018

Merge pull request #1718 from philsmd/master
fixes #1708: reject invalid masks with only a single ? at the end
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment