fixes #1338: hexify also all password of format $HEX[] #1340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem as described in #1338 could be that in very rare situation whenever the raw password was indeed starting with $HEX[ and ending with ] (and in between has only hex chars 0-9a-fA-F, the length is a multiple of 2), hashcat didn't convert it to $HEX[244845585b 5d] (i.e. hexify ($pass) where $pass is "$HEX[...]").
This could lead to a misinterpretation of the string because hashcat (if the plain was loaded again) would decode it as $HEX[] even if it was a raw password (and contain the literal sequence of bytes "$HEX[" and "]" at the end).
I suggest that in such a situation (very rare) we need to hexify the password again to avoid any confusion.
The user can always turn this behaviour of by using --outfile-autohex-disable.
Thx