Join GitHub today
fixes #1338: hexify also all password of format $HEX #1340
The problem as described in #1338 could be that in very rare situation whenever the raw password was indeed starting with $HEX[ and ending with ] (and in between has only hex chars 0-9a-fA-F, the length is a multiple of 2), hashcat didn't convert it to $HEX[244845585b 5d] (i.e. hexify ($pass) where $pass is "$HEX[...]").
This could lead to a misinterpretation of the string because hashcat (if the plain was loaded again) would decode it as $HEX even if it was a raw password (and contain the literal sequence of bytes "$HEX[" and "]" at the end).
I suggest that in such a situation (very rare) we need to hexify the password again to avoid any confusion.
The user can always turn this behaviour of by using --outfile-autohex-disable.