fixes #1708: reject invalid masks with only a single ? at the end #1718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue #1708 where a masks like ?a?a?a?a? was accepted as it was ?a?a?a?a?? .
Since the explanation on the wiki and faq make it very clear that we need to use ?? to represent a single quotation mark character within a mask, I would recommend that we make this more restrictive and reject every mask that doesn't comply with it.
BTW I looped/searched over all masks within the hashcat's "masks" directory and there was none that had a syntax error like this. we should be fine there and as @s3inlc mentioned we shouldn't allow masks that do not respect the "rules".
Thx