Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed colon separator inside hashes not to be dependent on the hashconfig separator #1727

Merged
merged 2 commits into from Oct 25, 2018

Conversation

@s3inlc
Copy link
Contributor

commented Oct 25, 2018

Some hashes use the colon as separator for their components, e.g. PBKDF2-HMAC-SHA256:

sha256:1000:MTc3MTA0MTQwMjQxNzY=:PYjCU215Mi57AYPKva9j7mvF4Rc5bCnt

But these should not be mixed with the separator used for the hash:plain output. But hashcat was expecting these also to change when the separator was set to another character (e.g. --separator #). But the way how the hash structure itself looks should be static (e.g. like with bcrypt with the $ separator).

Some of the hash modes (5500, 5600) already have the colon separator inside the hash set as constant. This now contains the changes for all the remaining hash modes where this would be the case: 4800, 6800, 8300, 8900, 10100,10900, 11900, 12000, 12100.

@s3inlc s3inlc changed the title Changed colon separator inside hashes not be dependent on the hashconfig separator Changed colon separator inside hashes not to be dependent on the hashconfig separator Oct 25, 2018
@jsteube jsteube merged commit f8124a1 into hashcat:master Oct 25, 2018
1 of 2 checks passed
1 of 2 checks passed
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.