Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Adding parser and basic kernels for -m 13500 #311
It's a good start, but we have to do some changes:
After this is done we can start with the kernel code
That looks much better. Following things are missing:
I think that would be great. I'll just make sure we have the tests in place, and remove the warning on compiling. Should be done in the next commit. Meanwhile, I will also fix the test.pl file for the new Digest::ECB versions, the constants are no longer exported.
Please don't use * here
Sorting of this:
You're still using an invalid option for the salt which you need to remove:
The following optimization is not possible since our data buffer is > length 55, you need to remove it:
Is wrong in two ways. First you should use sizeof():
Another problem is that you're using a value which is unknown at compile time to declare a number of elements in an array.
You should do:
More problems with snprintf():
Problem 1, the "%02x" does not match salt_buf which is 32 bit, not 8 bit. You propably need to something like this befoire you can use it:
Problem 2, the casting of pstoken_tmp from u8 * -> char * is not necessary.
Inside the parser you do:
I'd recommend to use the same declaration as in ascii_digest instead:
This optimization does not work here, because we need a 2nd call to sha1_transform because of the length > 55. You need to remove it:
That was easy stuff so fow, but now in test.pl it's getting real problematic. From your original issue you said:
What you totaly did not mention is the use of DES inside the algorithm. Now I'm very confused. Please explain in words how DES is involved in the process. It's important to write a proper kernel.
Aight. So at this point, we think we would need the kernels in order to test the full loop on our own and fix the remaining issues. Because it's the first time we touch the code base, having working kernels would help, and if you can help us with that, it would go much faster. Thanks for your patience btw ;)