-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add specific error classes for SDKClient and MirrorNodeCLient #382
Conversation
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Codecov Report
@@ Coverage Diff @@
## main #382 +/- ##
==========================================
+ Coverage 65.66% 73.65% +7.99%
==========================================
Files 8 10 +2
Lines 798 820 +22
Branches 130 133 +3
==========================================
+ Hits 524 604 +80
+ Misses 237 170 -67
- Partials 37 46 +9
Continue to review full report at Codecov.
|
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
…hgraph/hedera-json-rpc-relay into 213-add-client-error-classes
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice start.
Let's move some of the logic into the error class files
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there. 1 modification 2 nits
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Signed-off-by: lukelee-sl <luke.lee@swirldslabs.com>
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Signed-off-by: lukelee-sl luke.lee@swirldslabs.com
Description:
Create error classes for SDKClient and MirrorNodeClient classes.
Related issue(s):
Fixes #213
Notes for reviewer:
Checklist