Add comparison analysis table for supported tool #427
Conversation
Signed-off-by: nikolay <n.atanasow94@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #427 +/- ##
==========================================
+ Coverage 73.65% 76.23% +2.57%
==========================================
Files 10 11 +1
Lines 835 913 +78
Branches 137 144 +7
==========================================
+ Hits 615 696 +81
+ Misses 172 165 -7
- Partials 48 52 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Nana-EC
added
documentation
tools/README.md
Outdated
| | Contract Deployment | ✅ | ✅ | ✅ | ✅ | | ||
| | Can use the contract instance after deploy without re-initialization | ✅ | ✅ | ❌ | ❌ | | ||
| | Contract Method Call | ✅ | ✅ | ✅ | ✅ | | ||
| | Contract Method Call Execution | ✅ | ✅ | ✅ | ✅ | |
There was a problem hiding this comment.
Can you add a note under the table highlighted the re-initialization issue.
You can also note the ethersjs bug so that there's transparency to the community.
| @@ -0,0 +1,8 @@ | |||
| ### Supported tools | |||
There was a problem hiding this comment.
Add the following sentence
"The JSON RPC relay serves as an interface to the Hedera network for ethereum developer tools that utilize the implemented JSON RPC APIs
The following development tools have been tested and the extent of their coverage is noted below"
tools/README.md
Outdated
| | | web3js | Truffle | ethers | Hardhat | | ||
| |----------------------------------------------------------------------|--------|---------|--------|---------| | ||
| | Transfer HBARS | ✅ | ✅ | ✅ | ✅ | | ||
| | Contract Deployment | ✅ | ✅ | ✅ | ✅ | |
There was a problem hiding this comment.
| | Contract Deployment | ✅ | ✅ | ✅ | ✅ | | |
| | Contract Deployment | ✅ | ✅ | ✅ | ✅ | |
tools/README.md
Outdated
| | Contract Method Call | ✅ | ✅ | ✅ | ✅ | | ||
| | Contract Method Call Execution | ✅ | ✅ | ✅ | ✅ | |
There was a problem hiding this comment.
| | Contract Method Call | ✅ | ✅ | ✅ | ✅ | | |
| | Contract Method Call Execution | ✅ | ✅ | ✅ | ✅ | | |
| | Contract View Function Call | ✅ | ✅ | ✅ | ✅ | | |
| | Contract Function Call | ✅ | ✅ | ✅ | ✅ | |
Signed-off-by: nikolay <n.atanasow94@gmail.com>
tools/README.md
Outdated
| Note: On contract deployment, most of the tools (e.g. [ethers](https://docs.ethers.io/v5/api/utils/address/#utils--contract-addresses)) pre-compute the contract address on the client-side, based | ||
| on sender address and nonce. In the Hedera ecosystem, it's not like that, where it's just the next available id. | ||
|
|
||
| ##### The JSON RPC relay serves as an interface to the Hedera network for ethereum developer tools that utilize the implemented JSON RPC APIs. The following development tools have been tested and the extent of their coverage is noted below. |
There was a problem hiding this comment.
nit: this line should be above the Supported tools as the first statement
Signed-off-by: nikolay <n.atanasow94@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
natanasow
deleted the
380-comparison-analysis-table-for-supported-tools
branch
Signed-off-by: nikolay n.atanasow94@gmail.com
Description:
Related issue(s):
Fixes #380
Notes for reviewer:
Checklist