New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose entity_id in transactions REST API #1791
Conversation
Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## master #1791 +/- ##
============================================
- Coverage 87.37% 87.31% -0.07%
+ Complexity 1737 1732 -5
============================================
Files 315 315
Lines 7676 7676
Branches 732 732
============================================
- Hits 6707 6702 -5
- Misses 740 745 +5
Partials 229 229
Continue to review full report at Codecov.
|
Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
hedera-mirror-rest/__tests__/specs/transactions-30-specific-id-tokenwipe.spec.json
Outdated
Show resolved
Hide resolved
Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
SonarCloud Quality Gate failed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Detailed description:
Currently there's no way to know from an entity impacting transaction what the entity_id is e.g. a transaction that creates a crypto account doesn't say what the entityId is
entity_id
from transaction into select statement for transactionsWhich issue(s) this PR fixes:
Fixes #1639
Special notes for your reviewer:
Checklist