Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose entity_id in transactions REST API #1791

Merged
merged 3 commits into from Apr 3, 2021
Merged

Conversation

Nana-EC
Copy link
Collaborator

@Nana-EC Nana-EC commented Mar 31, 2021

Detailed description:
Currently there's no way to know from an entity impacting transaction what the entity_id is e.g. a transaction that creates a crypto account doesn't say what the entityId is

  • Add entity_id from transaction into select statement for transactions
  • Update spec test files with new column
  • Update mock pool file to support new column

Which issue(s) this PR fixes:
Fixes #1639

Special notes for your reviewer:

Checklist

  • Documentation added
  • Tests updated

Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
@Nana-EC Nana-EC added enhancement Type: New feature P2 rest Area: REST API javascript Pull requests that update Javascript code labels Mar 31, 2021
@Nana-EC Nana-EC added this to the Mirror 0.31.0 milestone Mar 31, 2021
@Nana-EC Nana-EC requested a review from a team March 31, 2021 16:35
@Nana-EC Nana-EC self-assigned this Mar 31, 2021
@codecov
Copy link

codecov bot commented Mar 31, 2021

Codecov Report

Merging #1791 (ad6f6eb) into master (0fc757c) will decrease coverage by 0.06%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1791      +/-   ##
============================================
- Coverage     87.37%   87.31%   -0.07%     
+ Complexity     1737     1732       -5     
============================================
  Files           315      315              
  Lines          7676     7676              
  Branches        732      732              
============================================
- Hits           6707     6702       -5     
- Misses          740      745       +5     
  Partials        229      229              
Impacted Files Coverage Δ Complexity Δ
.../importer/parser/record/entity/EntityListener.java 50.00% <0.00%> (-35.72%) 7.00% <0.00%> (-5.00%)
transactions.js 98.11% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b47a64...ad6f6eb. Read the comment docs.

Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
@Nana-EC Nana-EC marked this pull request as ready for review March 31, 2021 20:38
Signed-off-by: Nana-EC <56320167+Nana-EC@users.noreply.github.com>
@sonarcloud
Copy link

sonarcloud bot commented Apr 1, 2021

Copy link
Member

@steven-sheehy steven-sheehy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nana-EC Nana-EC merged commit efa57fa into master Apr 3, 2021
@Nana-EC Nana-EC deleted the transaction-entity-id branch April 3, 2021 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Type: New feature javascript Pull requests that update Javascript code P2 rest Area: REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expose entity_id on /api/v1/transactions endpoint
4 participants