0.35 - Cherry pick precompile permission change #5572
Merged
+1,303
−839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
tinker-michaelj
added
CI:UnitTests
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Nana-EC
requested review from
shemnon,
stoqnkpL,
david-bakin-sl,
lukelee-sl and
Neeharika-Sompalli
Neeharika-Sompalli
previously approved these changes
Mar 10, 2023
Neeharika-Sompalli
reviewed
Mar 10, 2023
Neeharika-Sompalli
changed the title
Nana-EC
previously approved these changes
Mar 11, 2023
The latest changes and the integration/E2E test fixes from the other PR have not been picked here, that's why some of the tests are failing. |
dimitar-dinev
reviewed
Mar 13, 2023
...java/com/hedera/node/app/service/mono/store/contracts/precompile/HTSPrecompiledContract.java
Show resolved
Hide resolved
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## release/0.35 #5572 +/- ##
===============================================
Coverage ? 95.36%
Complexity ? 16348
===============================================
Files ? 1185
Lines ? 46714
Branches ? 4762
===============================================
Hits ? 44548
Misses ? 1335
Partials ? 831 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.
|
nickpoorman
reviewed
Mar 13, 2023
buildSrc/src/main/kotlin/com.hedera.hashgraph.jpms-modules.gradle.kts
Outdated
Show resolved
Hide resolved
nickpoorman
reviewed
Mar 13, 2023
...java/com/hedera/node/app/service/mono/store/contracts/precompile/HTSPrecompiledContract.java
Show resolved
Hide resolved
nickpoorman
reviewed
Mar 13, 2023
...st/java/com/hedera/node/app/service/mono/store/contracts/precompile/InvalidDelegateTest.java
Show resolved
Hide resolved
Neeharika-Sompalli
reviewed
Mar 13, 2023
...java/com/hedera/node/app/service/mono/store/contracts/precompile/HTSPrecompiledContract.java
Show resolved
Hide resolved
Neeharika-Sompalli
previously approved these changes
Mar 13, 2023
shemnon
reviewed
Mar 13, 2023
| NOT_SUPPORTED_TXN, | ||
| CONTRACT_REVERT_EXECUTED, | ||
| recordWith().status(NOT_SUPPORTED))); | ||
| .hasCostAnswerPrecheck(INVALID_ACCOUNT_ID)); |
There was a problem hiding this comment.
We should revisit this test case. It doesn't depend on delegate call, the bytecode just happens to have outdated HederaTokenService.sol compiled in.
shemnon
reviewed
Mar 13, 2023
lukelee-sl
previously approved these changes
Mar 14, 2023
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
…recompile-permission-change
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
Signed-off-by: Michael Tinker <michael.tinker@swirldslabs.com>
|
SonarCloud Quality Gate failed. |
Neeharika-Sompalli
approved these changes
Mar 14, 2023
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Description:
delegatecall's to precompile contracts.contracts.permittedDelegateCallers=whitelist to allow contracts known to be safe to bypass the default limitation.