Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TerminatingGateway CRD #408

Merged
merged 1 commit into from
Dec 17, 2020
Merged

TerminatingGateway CRD #408

merged 1 commit into from
Dec 17, 2020

Conversation

lkysow
Copy link
Member

@lkysow lkysow commented Nov 27, 2020 •
edited
Loading

Changes proposed in this PR:

  • TerminatingGateway CRD

How I've tested this PR:

How I expect reviewers to test this PR:

  • Can use acceptance test, can also try and run through terminating gateway tutorial and use the CRD instead of the config entry. Use k8s image ghcr.io/lkysow/consul-k8s-dev:nov27.

Checklist:

  • Tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

@lkysow lkysow mentioned this pull request Nov 27, 2020
Merged
thisisnotashwin
thisisnotashwin reviewed Dec 14, 2020
View reviewed changes
Copy link
Contributor

@thisisnotashwin thisisnotashwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this the easiest CRD of them all? Nicely done @lkysow 👑

ishustava
ishustava approved these changes Dec 17, 2020
View reviewed changes
Copy link
Contributor

@ishustava ishustava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Base automatically changed from igw-crd to master December 17, 2020 21:06
@lkysow lkysow merged commit 00bbbb6 into master Dec 17, 2020
@lkysow lkysow deleted the tgw-crd branch December 17, 2020 21:13
ndhanushkodi pushed a commit to ndhanushkodi/consul-k8s that referenced this pull request Jul 9, 2021
@ishustava
Update CHANGELOG (hashicorp#408)
0a98bb6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ishustava ishustava ishustava approved these changes

@thisisnotashwin thisisnotashwin thisisnotashwin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lkysow @ishustava @thisisnotashwin