Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

values.yaml: Make it more clear how to utilize connectInject.namespaceSelector #703

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

david-yu
Copy link
Contributor

@david-yu david-yu commented Aug 31, 2021

Describe that connectInject.default should be used if trying to enable/disable connectInject by default. Addresses: #698

Changes proposed in this PR:

  • Comment to describe you should use namespaceSelector with `connectInject.default

How I've tested this PR:

❯ cat config.yaml
global:
  name: consul
  datacenter: dc1
  tls:
    enabled: true
server:
  replicas: 1
ui:
  enabled: true
meshGateway:
  enabled: true
  replicas: 1
connectInject:
  enabled: true
  default: true
  namespaceSelector: |
    matchLabels:
      connect-inject : enabled
controller:
  enabled: true

❯ kubectl describe ns foo
Name:         foo
Labels:       connect-inject=enabled
Annotations:  <none>
Status:       Active

Resource Quotas
 Name:                              gke-resource-quotas
 Resource                           Used  Hard
 --------                           ---   ---
 count/ingresses.extensions         0     100
 count/ingresses.networking.k8s.io  0     100
 count/jobs.batch                   0     5k
 pods                               2     1500
 services                           2     500

No LimitRange resource.

❯ kubectl get pods -n foo
NAME                        READY   STATUS    RESTARTS   AG
tcp-echo-866d7f8dcb-wxqnt   2/2     Running   0          70s

❯ kubectl get pods -n bar
NAME                        READY   STATUS    RESTARTS   AGE
tcp-echo-866d7f8dcb-n7j8s   1/1     Running   0          59s

How I expect reviewers to test this PR:

Checklist:

  • Tests added
  • CHANGELOG entry added (HashiCorp engineers only, community PRs should not add a changelog entry)

…eSelector

Describe that `connectInject.default` should be used if trying to enable/disable `connectInject` by default. Addresses: #698
@david-yu david-yu requested a review from lkysow August 31, 2021 18:07
@david-yu david-yu changed the title values.yaml: Make it more clear how to utilize connectInject.namespac… values.yaml: Make it more clear how to utilize connectInject.namespaceSelector Aug 31, 2021
charts/consul/values.yaml Outdated Show resolved Hide resolved
@david-yu david-yu merged commit a81d9a1 into main Aug 31, 2021
@david-yu david-yu deleted the david-yu-patch-1 branch August 31, 2021 22:16
lawliet89 pushed a commit to lawliet89/consul-k8s that referenced this pull request Sep 13, 2021
Occasionally we see kubectl commands failing due to temporary issues
connecting to the Kubernetes API. We should retry on these errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants